Expand curriculum RAG surface#16
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 53 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/web/app/app/new/export/view.tsx">
<violation number="1" location="packages/web/app/app/new/export/view.tsx:217">
P2: `useEffect` uses `schoolLevel` but omits it from dependencies, causing stale export data when school level changes.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| try { | ||
| const raw = window.sessionStorage.getItem( | ||
| storageKey(grade, topic, mode, dims, sourceProblemText), | ||
| storageKey(schoolLevel, grade, topic, mode, dims, sourceProblemText), |
There was a problem hiding this comment.
P2: useEffect uses schoolLevel but omits it from dependencies, causing stale export data when school level changes.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/web/app/app/new/export/view.tsx, line 217:
<comment>`useEffect` uses `schoolLevel` but omits it from dependencies, causing stale export data when school level changes.</comment>
<file context>
@@ -204,10 +211,10 @@ export function ExportView({
try {
const raw = window.sessionStorage.getItem(
- storageKey(grade, topic, mode, dims, sourceProblemText),
+ storageKey(schoolLevel, grade, topic, mode, dims, sourceProblemText),
);
if (raw === null) return;
</file context>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
smilebank7
force-pushed
the
feat/rag-curriculum-surface
branch
from
11587a8 to
b3c81fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
school_levelto the agentNotes
chore/gpt-55-xhigh-defaults) to avoid mixing this work into the existing GPT-5.5 defaults PR. Retarget tomainafter Set GPT-5.5 xhigh as agent default #15 merges.Verification
pnpm typecheckpnpm testpnpm -F @openmath/web buildschool_level=high,grade=null,topic=10공수01-01returned refsSummary by cubic
Expands the RAG surface to include high-school common math and fills middle-school gaps, aligning topic codes end-to-end. Threads school level through the web flow and agent, allowing nullable grade for high school.
New Features
10공수*) and additional middle-school (9수*) topics; topic catalog now includes high common-math and “집합과 명제.”gradeis now nullable; middle-school still requires grade;school_leveladded to generate requests; generation-kind mapping extended for10공수*.grade=null, validation that middle requires grade, and expanded strategy loader (now 43 strategies).schoolparam across S1–S6; grade picker supports “고등 공통수학”; labels and storage keys include school level; routes passschoolandgrade=commonfor high common; examples and copy updated..playwright-mcp/.Migration
packages/agent/scripts/build-expanded-rag-corpus.py(OCR corpus build is optional).school=high&grade=commonin URLs.Written for commit b3c81fc. Summary will update on new commits.